NcAppSidebarTabs: fix activating the tab being added #4004
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: nextcloud/spreed#9345
Steps to reproduce
A
,C
toNcAppSidebarTabs
B
add add tabB
Actual behavior
New tab is added, but not active.
Expected behavior
New tab is added and active.
Fix
Local
activeTab
should be updated on each new tab registration. Previously it was updated only if it wasn't set before (I have no ideas, why).Manual testing example
It's a bit specific, I decided not to add it to the documentation.